Checkstyle Results

The following document contains the results of Checkstyle .

Summary

Files Errors
69 7022

Files

Files Errors
org/mythsim/console/Main.java 1
org/mythsim/console/Main.java 4
org/mythsim/console/MainConsole.java 1
org/mythsim/console/MainConsole.java 9
org/mythsim/console/MythSimConsole.java 1
org/mythsim/console/MythSimConsole.java 6
org/mythsim/console/package.html 1
org/mythsim/core/ControlWord.java 1
org/mythsim/core/ControlWord.java 207
org/mythsim/core/MemParser.java 436
org/mythsim/core/MythError.java 60
org/mythsim/core/MythParser.java 1
org/mythsim/core/MythParser.java 121
org/mythsim/core/MythParserError.java 40
org/mythsim/core/MythSim.java 381
org/mythsim/core/UcodeParser.java 2094
org/mythsim/core/Yytoken.java 4
org/mythsim/swing/Console.java 1
org/mythsim/swing/Console.java 71
org/mythsim/swing/FileJDialog.java 1
org/mythsim/swing/FileJDialog.java 35
org/mythsim/swing/Main.java 1
org/mythsim/swing/Main.java 8
org/mythsim/swing/MainAboutJDialog.java 1
org/mythsim/swing/MainAboutJDialog.java 51
org/mythsim/swing/MainJFrame.java 1
org/mythsim/swing/MainJFrame.java 53
org/mythsim/swing/MainJPanel.java 1
org/mythsim/swing/MainJPanel.java 22
org/mythsim/swing/MainJToolBar.java 1
org/mythsim/swing/MainJToolBar.java 21
org/myt hsim/swing/MythMenuBar.java 1
org/mythsim/swing/MythMenuBar.java 64
org/mythsim/swing/MythSimSwing.java 1
org/mythsim/swing/MythSimSwing.java 130
org/mythsim/swing/plugin/ALUFrame.java 1
org/mythsim/swing/plugin/ALUFrame.java 398
org/mythsim/swing/plugin/DatapathAnimationFrame.java 604
org/mythsim/swing/plugin/DatapathFrame.java 1
org/mythsim/swing/plugin/DatapathFrame.java 514
org/mythsim/swing/plugin/LocationFrame.java 1
org/mythsim/swing/plugin/LocationFrame.java 77
org/mythsim/swing/plugin/MemoryFrame.java 1
org/mythsim/swing/plugin/MemoryFrame.java 395
org/mythsim/swing/plugin/MemorySourceFrame.java 1
org/mythsim/swing/plugin/MemorySourceFrame.java 166
org/mythsim/swing/plugin/MicrocodeSourceFrame.java 1
org/mythsim/swing/plugin/MicrocodeSourceFrame.java 153
org/mythsim/swing/plugin/MicrostoreFrame.java 58
org/mythsim/swing/plugin/MythPlugInFrame.java 139
org/mythsim/swing/plugin/PluginFrame.java 1
org/mythsim/swing/plugin/PluginFrame.java 37
org/mythsim/swing/plugin/RegisterF rame.java 185
org/mythsim/text/Text.java 457

org/mythsim/console/Main.java

Error Line
File does not end with a newline. 0

org/mythsim/console/Main.java

Error Line
Missing a header - not enough lines in file. 1
Utility classes should not have a public or default constructor. 28
Missing a Javadoc comment. 29
Parameter args should be final. 29

org/mythsim/console/MainConsole.java

Error Line
File does not end with a newline. 0

org/mythsim/console/MainConsole.java

Error Line
Missing a header - not enough lines in file. 1
Using the '.*' form of import should be avoided - java.io.*. 23
Using the '.*' form of import should be avoided - org.mythsim.core.*. 24
Missing a Javadoc comment. 31
Missing a Javadoc comment. 33
'}' should be on the same line. 37
'}' should be on the same line. 58
'}' should be on the same line. 62
'}' should be on the same line. 66

org/mythsim/console/MythSimConsole.java

Error Line
File does not end with a newline. 0

org/mythsim/console/MythSimConsole.java

Error Line
Missing a header - not enough lines in file. 1
Missing a Javadoc comment. 32
Method 'print_registers' is not designed for extension - needs to be abstract, final or empty. 36
Missing a Javadoc comment. 36
Name 'print_registers' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 36
Array brackets at illegal position. 37

org/mythsim/console/package.html

Error Line
Missing package documentation file. 0

org/mythsim/core/ControlWord.java

Error Line
File does not end with a newline. 0

org/mythsim/core/ControlWord.java

Error Line
Line does not match expected header line of ' GNU GENERAL PUBLIC LICENSE'. 1
Missing a Javadoc comment. 29
Missing a Javadoc comment. 30
Missing a Javadoc comment. 31
Missing a Javadoc comment. 32
Missing a Javadoc comment. 33
Missing a Javadoc comment. 34
Missing a Javadoc comment. 35
Missing a Javadoc comment. 36
Missing a Javadoc comment. 37
Missing a Javadoc comment. 38
Missing a Javadoc comment. 39
Missing a Javadoc comment. 40
Missing a Javadoc comment. 41
Missing a Javadoc comment. 42
Missing a Javadoc comment. 43
Missing a Javadoc comment. 44
Missing a Javadoc comment. 45
Missing a Javadoc comment. 46
Missing a Javadoc comment. 47
Missing a Javadoc comment. 48
Missing a Javadoc comment. 49
Missing a Javadoc comment. 50
Missing a Javadoc comment. 51
Missing a Javadoc comment. 52
Missing a Javadoc comment. 53
Missing a Javadoc comment. 54
Missing a Javadoc comment. 55
Missing a Javadoc comment. 56
Missing a Javadoc comment. 57
Missing a Javadoc comment. 58
Missing a Javadoc comment. 59
Missing a Javadoc comment. 60
Missing a Javadoc comment. 61
Missing a Javadoc comment. 62
Missing a Javadoc comment. 63
Missing a Javadoc comment. 64
Missing a Javadoc comment. 65
Missing a Javadoc comment. 66
Missing a Javadoc comment. 67
Missing a Javadoc comment. 68
Missing a Javadoc comment. 69
Missing a Javadoc comment. 70
Missing a Javadoc comment. 71
Missing a Javadoc comment. 72
Missing a Javadoc comment. 73
Missing a Javadoc comment. 74
Missing a Javadoc comment. 75
Missing a Javadoc comment. 76
Missing a Javadoc comment. 77
Missing a Javadoc comment. 78
Missing a Javadoc comment. 79
Missing a Javadoc comment. 80
Missing a Javadoc comment. 81
Missing a Javadoc comment. 82
Missing a Javadoc comment. 83
Name 'ControlLine' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 85
Variable 'ControlLine' must be private and have accessor methods. 85
Array brackets at illegal position. 85
Missing a Javadoc comment. 85
Name 'ControlLine_Set' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 86
Variable 'ControlLine_Set' must be private and have accessor methods. 86
Array brackets at illegal position. 86
Missing a Javadoc comment. 86
Missing a Javadoc comment. 87
Name '_original_line' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 87
Variable '_original_line' must be private and have accessor methods. 87
Method 'get' is not designed for extension - needs to be abstract, final or empty. 89
Missing a Javadoc comment. 89
Parameter index should be final. 89
Method 'isSet' is not designed for extension - needs to be abstract, final or empty. 93
Missing a Javadoc comment. 93
Parameter index should be final. 93
Method 'set' is not designed for extension - needs to be abstract, final or empty. 97
Missing a Javadoc comment. 97
Parameter index should be final. 97
Method 'print' is not designed for extension - needs to be abstract, final or empty. 101
Missing a Javadoc comment. 101
Parameter index should be final. 101
Method 'toArray' is not designed for extension - needs to be abstract, final or empty. 105
Missing a Javadoc comment. 105
Method 'line' is not designed for extension - needs to be abstract, final or empty. 109
Missing a Javadoc comment. 109
Missing a Javadoc comment. 117
Name 'alu_value' must match pattern '^[A-Z ] (_?[A-Z0-9 ] +)*$'. 117
Array brackets at illegal position. 117
Missing a Javadoc comment. 119
Name 'mar_value' must match pattern '^[A-Z ] (_?[A-Z0-9 ] +)*$'. 119
Array brackets at illegal position. 119
Missing a Javadoc comment. 121
Name 'mdr_value' must match pattern '^[A-Z ] (_?[A-Z0- 9 ] +)*$'. 121
Array brackets at illegal position. 121
Missing a Javadoc comment. 123
Name 'result_value' must match pattern '^[A-Z ] (_?[A-Z0-9 ] +)*$'. 123
Array brackets at illegal position. 123
Missing a Javadoc comment. 125
Name 'ir_value' must match pattern '^[A-Z ] (_?[A-Z0-9 ] +)*$'. 125
Array brackets at illegal position. 125
Missing a Javadoc comment. 127
Name 'cond_value' must match pattern '^[A-Z ] (_?[A-Z0-9 ] +)*$'. 127
Array brackets at illegal position. 127
Missing a Javadoc comment. 129
Name 'control_line_value' must match pattern '^[A-Z ] (_?[A-Z0-9 ] +)*$'. 129
Array brackets at illegal position. 129
Missing a Javadoc comment. 138
Name 'original_line' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 138
Variable 'original_line' must be private and have accessor methods. 138
Method 'setAddress' is not designed for extension - needs to be abstract, final or empty. 140
Missing a Javadoc comment. 140
Parameter a should be final. 140
Method 'setLabel' is not designed for extension - needs to be abstract, final or empty. 144
Missing a Javadoc comment. 144
Parameter s should be final. 144
Method 'setTrueLabel' is not designed for extension - needs to be abstract, final or empty. 148
Missing a Javadoc comment. 148
Parameter s should be final. 148
Method 'setFalseLabel' is not designed for extension - needs to be abstract, final or empty. 152
Missing a Javadoc comment. 152
Parameter s should be final. 152
Method 'setLineNumber' is not designed for extension - needs to be abstract, final or empty. 156
Missing a Javadoc comment. 156
Parameter i should be final. 156
Method 'getLineNumber' is not designed for extension - needs to be abstract, final or empty. 160
Missing a Javadoc comment. 160
Method 'getTrueLabel' is not designed for extension - needs to be abstract, final or empty. 164
Missing a Javadoc comment. 164
Method 'getFalseLabel' is not designed for extension - needs to be abstract, final or empty. 168
Missing a Javadoc comment. 168
Method 'address' is not designed for extension - needs to be abstract, final or empty. 173
Missing a Javadoc comment. 173
'10' is a magic number. 175
'100' is a magic number. 178
'1000' is a magic number. 181
Method 'print' is not designed for extension - needs to be abstract, final or empty. 188
Missing a Javadoc comment. 188
Parameter a should be final. 188
Method 'printAddress' is not designed for extension - needs to be abstract, final or empty. 192
Missing a Javadoc comment. 192
Missing a Javadoc comment. 196
Name '_address' mu st match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 196
Variable '_address' must be private and have accessor methods. 196
Method 'label' is not designed for extension - needs to be abstract, final or empty. 198
Missing a Javadoc comment. 198
Missing a Javadoc comment. 202
Name '_label' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 202
Variable '_label' must be private and have accessor methods. 202
Missing a Javadoc comment. 203
Name '_true_label_found' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 203
Variable '_true_label_found' must be private and have accessor methods. 203
Missing a Javadoc comment. 204
Name '_false_label_found' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 204
Variable '_false_label_found' must be private and have accessor methods. 204
Missing a Javadoc comment. 205
Name '_line_number' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 205
Variable '_line_number' must be private and have accessor methods. 205
Missing a Javadoc comment. 206
Name '_address_string' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 206
Variable '_address_string' must be private and have accessor methods. 206
Missing a Javadoc comment. 207
Name '_address_true_string' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 207
Variable '_address_true_string' must be private and have accessor methods. 207
Missing a Javadoc comment. 208
Name '_address_true_offset_string' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 208
Variable '_address_true_offset_string' must be private and have accessor methods. 208
Missing a Javadoc comment. 209
Name '_address_false_string' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 209
Variable '_address_false_string' must be private and have accessor methods. 209
Missing a Javadoc comment. 210
Name '_address_false_offset_string' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 210
Variable '_address_false_offset_string' must be private and have accessor methods. 210
Line is longer than 80 characters. 245
Line is longer than 80 characters. 320
Method 'set' is not designed for extension - needs to be abstract, final or empty. 369
Missing a Javadoc comment. 369
Parameter index should be final. 369
Parameter value should be final. 369
'+' is not preceeded with whitespace. 371
'+' is not followed by whitespace. 371
Missing a Javadoc comment. 374
Line is longer than 80 characters. 391
Line is longer than 80 characters. 393
Line is longer than 80 characters. 395
Method 'print' is not designed for extension - needs to be abstract, final or empty. 398
Missing a Javadoc comment. 398
'10' is a magic number. 443
'100' is a magic number. 446
'1000' is a magic number. 449
'10' is a magic number. 454
'100' is a magic number. 457
'1000' is a magic number. 460
'+' should be on a new line. 465
Method 'print_addr' is not designed for extension - needs to be abstract, final or empty. 469
Missing a Javadoc comment. 469
Name 'print_addr' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 469
Method 'resolve_addr' is not designed for extension - needs to be abstract, final or empty. 478
Missing a Javadoc comment. 478
Name 'resolve_addr' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 478
Array brackets at illegal position. 478
Parameter a should be final. 478
Line is longer than 80 characters. 481
Line is longer than 80 characters. 501
Conditional logic can be removed. 502
'}' should be on the same line. 504
Method 'validTrueLabel' is not designed for extension - needs to be abstract, final or empty. 510
Missing a Javadoc comment. 510
Method 'validFalseLabel' is not designed for extension - needs to be abstract, final or empty. 514
Missing a Javadoc comment. 514

org/mythsim/core/MemParser.java

Error Line
Line does not match expected header line of ' GNU GENERAL PUBLIC LICENSE'. 1
Using the '.*' form of import should be avoided - java.io.*. 24
Using the '.*' form of import should be avoided - java.util.*. 25
Line is longer than 80 characters. 31
'public' modifier out of order with the JLS suggestions. 36
'private' modifier out of order with the JLS suggestions. 39
'public' modifier out of order with the JLS suggestions. 42
'private' modifier out of order with the JLS suggestions. 47
Name 'yycmap' must match pattern '^[A-Z ] (_?[A-Z0-9 ] +)*$'. 47
'7' is a magic number. 48
'8' is a magic number. 48
'5' is a magic number. 50
'9' is a magic number. 50
'8' is a magic number. 50
'6' is a magic number. 50
'10' is a magic number. 50
'4' is a magic number. 51
'4' is a magic number. 51
'3' is a magic number. 51
'private' modifier out of order with the JLS suggestions. 61
Name 'yy_rowMap' must match pattern '^[A-Z ] (_?[A-Z0-9 ] +)*$'. 61
Array brackets at illegal position. 61
'11' is a magic number. 62
'22' is a magic number. 62
'33' is a magic number. 62
'11' is a magic number. 62
'44' is a magic number. 62
'55' is a magic number. 62
'66' is a magic number. 62
'11' is a magic number. 62
'77' is a magic number. 62
'11' is a magic number. 63
'88' is a magic number. 63
'99' is a magic number. 63
'110' is a magic number. 63
'121' is a magic number. 63
'132' is a magic number. 63
'110' is a magic number. 63
'143' is a magic number. 63
'154' is a magic number. 63
'165' is a magic number. 63
'176' is a magic number. 64
'187' is a magic number. 64
'198' is a magic number. 64
'209' is a magic number. 64
'220' is a magic number. 64
'231' is a magic number. 64
'242' is a magic number. 64
'253' is a magic number. 64
'private' modifier out of order with the JLS suggestions. 70
Name 'yy_packed0' must match pattern '^[A-Z ] (_?[A-Z0-9 ] +)*$'. 70
'+' is not preceeded with whitespace. 71
'+' should be on a new line. 71
'+' is not preceeded with whitespace. 72
'+' should be on a new line. 72
'+' is not preceeded with whitespace. 73
'+' should be on a new line. 73
'+' is not preceeded with whitespace. 74
'+' should be on a new line. 74
'+' is not preceeded with whitespace. 75
'+' should be on a new line. 75
'+' is not preceeded with whitespace. 76
'+' should be on a new line. 76
'+' is not preceeded with whitespace. 77
'+' should be on a new line. 77
'+' is not preceeded with whitespace. 78
'+' should be on a new line. 78
'+' is not preceeded with whitespace. 79
'+' should be on a new line. 79
'+' is not preceeded with whitespace. 80
'+' should be on a new line. 80
'+' is not preceeded with whitespace. 81
'+' should be on a new line. 81
'+' is not preceeded with whitespace. 82
'+' should be on a new line. 82
'+' is not preceeded with whitespace. 83
'+' should be on a new line. 83
'+' is not preceeded with whitespace. 84
'+' should be on a new line. 84
'+' is not preceeded with whitespace. 85
'+' should be on a new line. 85
'+' is not preceeded with whitespace. 86
'+' should be on a new line. 86
'+' is not preceeded with whitespace. 87
'+' should be on a new line. 87
'+' is not preceeded with whitespace. 88
'+' should be on a new line. 88
'private' modifier out of order with the JLS suggestions. 94
Name 'yytrans' must match pattern '^[A-Z ] (_?[A-Z0-9 ] +)*$'. 94
Array brackets at illegal position. 94
Missing a Javadoc comment. 98
'private' modifier out of order with the JLS suggestions. 98
Missing a Javadoc comment. 99
'private' modifier out of order with the JLS suggestions. 99
Missing a Javadoc comment. 100
'private' modifier out of order with the JLS suggestions. 100
Missing a Javadoc comment. 101
'private' modifier out of order with the JLS suggestions. 101
Missing a Javadoc comment. 104
'private' modifier out of order with the JLS suggestions. 104
Array brackets at illegal position. 104
'static' modifier out of order with the JLS suggestions. 114
Array brackets at illegal position. 114
'9' is a magic number. 115
Name 'yy_reader' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 120
Name 'yy_state' mu st match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 123
Name 'yy_lexical_state' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 126
Name 'yy_buffer' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 130
Array brackets at illegal position. 130
Name 'yy_markedPos' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 133
Name 'yy_pushbackPos' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 136
Name 'yy_currentPos' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 139
Name 'yy_startRead' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 142
Name 'yy_endRead' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 146
Name 'yy_atBOL' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 163
Name 'yy_atEOF' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 166
Method 'parse' is not designed for extension - needs to be abstract, final or empty. 175
Missing a Javadoc comment. 175
Line contains a tab character. 176
'=' is not preceeded with whitespace. 176
'=' is not followed by whitespace. 176
' & lt;' is not preceeded with whitespace. 176
'256' is a magic number. 176
' & lt;' is not followed by whitespace. 176
Line contains a tab character. 177
'=' is not preceeded with whitespace. 177
'=' is not followed by whitespace. 177
Line contains a tab character. 178
Line contains a tab character. 180
Method 'isValid' is not designed for extension - needs to be abstract, final or empty. 184
Missing a Javadoc comment. 184
Line contains a tab character. 185
Method 'errorMessages' is not designed for extension - needs to be abstract, final or empty. 188
Missing a Javadoc comment. 188
Line contains a tab character. 189
'+' should be on a new line. 189
Line contains a tab character. 190
'+' should be on a new line. 190
Line contains a tab character. 191
'+' should be on a new line. 191
Line contains a tab character. 192
Line contains a tab character. 193
Line contains a tab character. 194
Line contains a tab character. 195
Line contains a tab character. 196
'+' should be on a new line. 196
Line contains a tab character. 197
'+' should be on a new line. 197
Line contains a tab character. 198
Line contains a tab character. 199
Method 'getMemoryArray' is not designed for extension - needs to be abstract, final or empty. 202
Missing a Javadoc comment. 202
Line contains a tab character. 203
Line contains a tab character. 210
Missing a Javadoc comment. 210
Name 'ERROR_MESSAGE_TOTAL' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 210
Variable 'ERROR_MESSAGE_TOTAL' must be private and have accessor methods. 210
Line contains a tab character. 211
Missing a Javadoc comment. 211
Name 'ERROR_MESSAGES' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 211
Variable 'ERROR_MESSAGES' must be private and have accessor methods. 211
Line contains a tab character. 212
Missing a Javadoc comment. 212
Name 'ERROR_DEFAULT_MESSAGE' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 212
Variable 'ERROR_DEFAULT_MESSAGE' must be private and have accessor methods. 212
Line contains a tab character. 213
Variable 'memory' must be private and have accessor methods. 213
Array brackets at illegal position. 213
Missing a Javadoc comment. 213
'256' is a magic number. 213
Line contains a tab character. 214
Missing a Javadoc comment. 214
Variable 'size' must be private and have accessor methods. 214
Line contains a tab character. 215
Missing a Javadoc comment. 215
Variable 'counter' must be private and have accessor methods. 215
Line contains a tab character. 216
Missing a Javadoc comment. 216
Name 'memory_address' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 216
Variable 'memory_address' must be private and have accessor methods. 216
Line contains a tab character. 222
Expected an @return tag. 223
Line contains a tab character. 223
Method 'parseValue' is not designed for extension - needs to be abstract, final or empty. 223
Parameter a should be final. 223
Expected @param tag for 'a'. 223
Line contains a tab character. 224
'8' is a magic number. 224
Line contains a tab character. 225
Line contains a tab character. 226
Line contains a tab character. 227
Line contains a tab character. 228
Line contains a tab character. 229
Line contains a tab character. 231
Expected an @return tag. 232
Line contains a tab character. 232
Method 'string2int' is not designed for extension - needs to be abstract, final or empty. 232
Parameter a should be final. 232
Expected @param tag for 'a'. 232
Line contains a tab character. 233
',' is not followed by whitespace. 233
Line contains a tab character. 234
'8' is a magic number. 234
Line contains a tab character. 235
Line contains a tab character. 236
Array brackets at illegal position. 236
'if' construct must use '{}'s. 237
Line contains a tab character. 237
'==' is not preceeded with whitespace. 237
'==' is not followed by whitespace. 237
'128' is a magic number. 237
'if' construct must use '{}'s. 238
Line contains a tab character. 238
'==' is not preceeded with whitespace. 238
'==' is not followed by whitespace. 238
'64' is a magic number. 238
'if' construct must use '{}'s. 239
Line contains a tab character. 239
'==' is not preceeded with whitespace. 239
'==' is not followed by whitespace. 239
'32' is a magic number. 239
'if' construct must use '{}'s. 240
Line contains a tab character. 240
'3' is a magic number. 240
'==' is not preceeded with whitespace. 240
'==' is not followed by whitespace. 240
'16' is a magic number. 240
'if' construct must use '{}'s. 241
Line contains a tab character. 241
'4' is a magic number. 241
'==' is not preceeded with whitespace. 241
'==' is not followed by whitespace. 241
'8' is a magic number. 241
'if' construct must use '{}'s. 242
Line contains a tab character. 242
'5' is a magic number. 242
'==' is not preceeded with whitespace. 242
'==' is not followed by whitespace. 242
'4' is a magic number. 242
'if' construct mus t use '{}'s. 243
Line contains a tab character. 243
'6' is a magic number. 243
'==' is not preceeded with whitespace. 243
'==' is not followed by whitespace. 243
'if' construct must use '{}'s. 244
Line contains a tab character. 244
'7' is a magic number. 244
'==' is not preceeded with whitespace. 244
'==' is not followed by whitespace. 244
Line contains a tab character. 245
Line contains a tab character. 246
Line contains a tab character. 247
'129' is a magic number. 247
Line contains a tab character. 248
Line contains a tab character. 249
Missing a Javadoc comment. 252
Missing a Javadoc comment. 254
Line contains a tab character. 255
Line contains a tab character. 256
',' is not followed by whitespace. 256
Line contains a tab character. 257
Line contains a tab character. 258
'255' is a magic number. 258
Line contains a tab character. 259
Line contains a tab character. 260
Line contains a tab character. 261
Line contains a tab character. 262
Line contains a tab character. 263
Line contains a tab character. 264
Missing a Javadoc comment. 266
Line contains a tab character. 267
Missing a Javadoc comment. 269
Name 'setBINARY_BYTE' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 269
Line contains a tab character. 270
Line contains a tab character. 271
Missing a Javadoc comment. 273
Name 'setDECIMAL_BYTE' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 273
Line contains a tab character. 274
Line contains a tab character. 275
'128' is a magic number. 275
'255' is a magic number. 275
Line contains a tab character. 276
Line contains a tab character. 277
Line is longer than 80 characters. 278
Line contains a tab character. 278
Line contains a tab character. 279
Line contains a tab character. 280
Missing a Javadoc comment. 283
Line contains a tab character. 284
Missing a Javadoc comment. 287
Parameter m should be final. 287
Line contains a tab character. 288
Line contains a tab character. 289
'+' is not preceeded with whitespace. 289
'+' is not followed by whitespace. 289
'+' should be on a new line. 289
Line contains a tab character. 290
Missing a Javadoc comment. 292
Parameter l should be final. 292
',' is not followed by whitespace. 292
Parameter m should be final. 292
Line contains a tab character. 293
Line contains a tab character. 294
'+' should be on a new line. 294
Line contains a tab character. 295
Parameter in should be final. 306
Parameter in should be final. 316
Name 'yy_unpack' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 325
'264' is a magic number. 326
Name 'yy_unpack' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 338
Parameter packed should be final. 338
Parameter offset should be final. 338
Expected @param tag for 'offset'. 338
Parameter trans should be final. 338
Expected @param tag for 'trans'. 338
'do' construct must use '{}'s. 346
Name 'yy_refill' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 359
'-' is not preceeded with whitespace. 365
'-' is not followed by whitespace. 365
'-=' is not preceeded with whitespace. 368
'-=' is not preceeded with whitespace. 369
'-=' is not preceeded with whitespace. 370
'-=' is not preceeded with whitespace. 371
Array brackets at illegal position. 378
'*' is not preceeded with whitespace. 378
'*' is not followed by whitespace. 378
'-' is not preceeded with whitespace. 385
'-' is not followed by whitespace. 385
'}' should be on the same line. 389
'+=' is not preceeded with whitespace. 391
'public' modifier out of order with the JLS suggestions. 400
Expected @throws tag for 'java.io.IOException'. 400
'if' construct must use '{}'s. 404
'public' modifier out of order with the JLS suggestions. 419
Parameter reader should be final. 419
Expected @throws tag for 'java.io.IOException'. 419
Inner assignments should be avoided. 424
Inner assignments should be avoided. 425
Inner assignments should be avoided. 425
Inner assignments should be avoided. 426
Inner assignments should be avoided. 426
Expected an @return tag. 434
'public' modifier out of order with the JLS suggestions. 434
'public' modifier out of order with the JLS suggestions. 444
Parameter newState should be final. 444
Expected an @return tag. 452
'public' modifier out of order with the JLS suggestions. 452
'(' is followed by whitespace. 453
'-' is not preceeded with whitespace. 453
'-' is not followed by whitespace. 453
')' is preceeded with whitespace. 453
'public' modifier out of order with the JLS suggestions. 468
Parameter pos should be final. 468
'+' is not preceeded with whitespace. 469
'+' is not followed by whitespace. 469
Expected an @return tag. 476
'public' modifier out of order with the JLS suggestions. 476
'-' is not preceeded with whitespace. 477
'-' is not followed by whitespace. 477
Name 'yy_ScanError' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 495
Parameter errorCode should be final. 495
'}' should be on the same line. 499
Parameter number should be final. 516
'if' construct must use '{}'s. 517
'(' is followed by whitespace. 517
')' is prece eded with whitespace. 517
Method 'yylex' is not designed for extension - needs to be abstract, final or empty. 531
Method length is 163 lines (max allowed is 150). 531
Name 'yy_input' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 532
Name 'yy_action' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 533
Name 'yy_currentPos_l' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 536
Name 'yy_startRead_l' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 537
Name 'yy_markedPos_l' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 538
Name 'yy_endRead_l' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 539
Name 'yy_buffer_l' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 540
Name 'yycmap_l' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 541
Name 'yytrans_l' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 543
Name 'yy_rowMap_l' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 544
Name 'yy_attr_l' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 545
Name 'yy_r' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 550
Line is longer than 80 characters. 552
'if' construct must use '{}'s. 567
Line is longer than 80 characters. 579
Name 'yy_peek' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 580
'if' construct mu st use '{}'s. 581
'if' construct must use '{}'s. 583
'if' construct must use '{}'s. 589
'else' construct must use '{}'s. 591
'if' construct must use '{}'s. 594
Inner assignments should be avoided. 598
Inner assignments should be avoided. 598
Inner assignments should be avoided. 599
'if' construct must use '{}'s. 607
'}' should be on the same line. 612
'}' should be on the same line. 626
Name 'yy_next' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 631
'if' construct must use '{}'s. 632
Name 'yy_attributes' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 635
'(' is followed by whitespace. 636
')' is preceeded with whitespace. 636
'if' construct must use '{}'s. 639
'(' is followed by whitespace. 639
'8' is a magic number. 639
'8' is a magic number. 639
')' is preceeded with whitespace. 639
'4' is a magic number. 650
Avoid nested blocks. 651
'29' is a magic number. 652
'9' is a magic number. 654
Avoid nested blocks. 655
'30' is a magic number. 656
'25' is a magic number. 657
'27' is a magic number. 658
Avoid nested blocks. 659
'31' is a magic number. 660
'3' is a magic number. 662
'5' is a magic number. 663
'6' is a magic number. 664
'11' is a magic number. 665
'14' is a magic number. 666
'17' is a magic number. 667
'19' is a magic number. 668
'21' is a magic number. 669
'23' is a magic number. 670
Avoid nested blocks. 671
'32' is a magic number. 672
'16' is a magic number. 673
Avoid nested blocks. 674
'33' is a magic number. 675
'7' is a magic number. 676
'8' is a magic number. 677
Avoid nested blocks. 678
'34' is a magic number. 679
Avoid nested blocks. 681
'35' is a magic number. 682
'}' should be on the same line. 687

org/mythsim/core/MythError.java

Error Line
Missing a header - not enough lines in file. 1
Line contains a tab character. 27
Missing a Javadoc comment. 27
Name '_title' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 27
Variable '_title' must be private and have accessor methods. 27
Line contains a tab character. 28
Missing a Javadoc comment. 28
Name '_message' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 28
Variable '_message' must be private and have accessor methods. 28
Line contains a tab character. 29
Missing a Javadoc comment. 29
Name '_pop_up' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 29
Variable '_pop_up' must be private and have accessor methods. 29
Line contains a tab character. 30
Missing a Javadoc comment. 30
Name '_line_number' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 30
Variable '_line_number' must be private and have accessor methods. 30
'=' is not preceeded with whitespace. 30
'=' is not followed by whitespace. 30
Line contains a tab character. 31
Missing a Javadoc comment. 31
'{' is not followed by whitespace. 31
'}' is not preceeded with whitespace. 31
Line contains a tab character. 32
Missing a Javadoc comment. 32
Parameter a should be final. 32
Line contains a tab character. 33
Line contains a tab character. 34
Line contains a tab character. 35
Missing a Javadoc comment. 35
Parameter a should be final. 35
Array brackets at illegal position. 35
Parameter s should be final. 35
Parameter b should be final. 35
Line contains a tab character. 36
Line contains a tab character. 37
Line contains a tab character. 38
Line contains a tab character. 39
Line contains a tab character. 40
Line contains a tab character. 41
Line contains a tab character. 42
Line contains a tab character. 43
Line contains a tab character. 44
'5' is a magic number. 44
Line is longer than 80 characters. 45
Line contains a tab character. 45
Line contains a tab character. 46
Line is longer than 80 characters. 47
Line contains a tab character. 47
Line contains a tab character. 48
Line contains a tab character. 49
Line contains a tab character. 50
Line contains a tab character. 51
Line contains a tab character. 52
Line contains a tab character. 53
Line contains a tab character. 54
Method 'message' is not designed for extension - needs to be abstract, final or empty. 54
Missing a Javadoc comment. 54
Line contains a tab character. 55
Line contains a tab character. 56

org/mythsim/core/MythParser.java

Error Line
File does not end with a newline. 0

org/mythsim/core/MythParser.java

Error Line
Missing a header - not enough lines in file. 1
Using the '.*' form of import should be avoided - java.io.*. 23
Using the '.*' form of import should be avoided - java.util.*. 24
Using the '.*' form of import should be avoided - javax.swing.*. 25
Using the '.*' form of import should be avoided - javax.swing.text.*. 26
Using the '.*' form of import should be avoided - java.awt.*. 27
Using the '.*' form of import should be avoided - org.mythsim.text.*. 28
Missing a Javadoc comment. 35
Variable 'memorySource' must be private and have accessor methods. 35
Missing a Javadoc comment. 36
Variable 'microcodeSource' must be private and have accessor methods. 36
Missing a Javadoc comment. 38
Variable 'ucodememory' must be private and have accessor methods. 38
Missing a Javadoc comment. 39
Variable 'ucodeSize' must be private and have accessor methods. 39
Missing a Javadoc comment. 40
Variable 'ucodeCounter' must be private and have accessor methods. 40
Missing a Javadoc comment. 41
Variable 'clock' must be private and have accessor methods. 41
Missing a Javadoc comment. 42
Variable 'startSelect' must be private and have accessor methods. 42
Variable 'memory' must be private and have accessor methods. 44
Array brackets at illegal position. 44
Missing a Javadoc comment. 44
'256' is a magic number. 44
Missing a Javadoc comment. 45
Variable 'size' must be private and have accessor methods. 45
Missing a Javadoc comment. 46
Variable 'counter' must be private and have accessor methods. 46
Missing a Javadoc comment. 47
Variable 'ms' must be private and have accessor methods. 47
Method 'getMicrocodeSource' is not designed for extension - needs to be abstract, final or empty. 52
Method 'toUcodeIntArray' is not designed for extension - needs to be abstract, final or empty. 56
Missing a Javadoc comment. 56
Array brackets at illegal position. 58
'(' is followed by whitespace. 60
Method 'toIntegerArray' is not designed for extension - needs to be abstract, final or empty. 68
Missing a Javadoc comment. 68
Array brackets at illegal position. 70
'27' is a magic number. 70
'(' is followed by whitespace. 72
'26' is a magic nu mber. 73
Method 'toUcodeObjectArray' is not designed for extension - needs to be abstract, final or empty. 80
Missing a Javadoc comment. 80
Array brackets at illegal position. 82
'27' is a magic number. 82
'(' is followed by whitespace. 85
'7' is a magic number. 87
'6' is a magic number. 88
'5' is a magic number. 89
'4' is a magic number. 90
'3' is a magic number. 91
'8' is a magic number. 96
'26' is a magic number. 96
'6' is a magic number. 97
Method 'toCodeArray' is not designed for extension - needs to be abstract, final or empty. 103
Missing a Javadoc comment. 103
Array brackets at illegal position. 105
'(' is followed by whitespace. 107
Missing a Javadoc comment. 113
'{' is not followed by whitespace. 113
'}' is not preceeded with whitespace. 113
Line is longer than 80 characters. 116
Parameter ucodeFile should be final. 116
Expected @param tag for 'ucodeFile'. 116
Parameter memFile should be final. 116
Expected @param tag for 'memFile'. 116
Parameter _ms should be final. 116
Expected @param tag for '_ms'. 116
Name '_ms' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 116
Expected @throws tag for 'Exception'. 116
'256' is a magic number. 142
'}' should be on the same line. 165
Method 'ustore' is not designed for extension - needs to be abstract, final or empty. 174
Missing a Javadoc comment. 174
'5' is a magic number. 177
'(' is followed by whitespace. 180
Method 'getMemorySource' is not designed for extension - needs to be abstract, final or empty. 187
Method 'notDone' is not designed for extension - needs to be abstract, final or empty. 191
Missing a Javadoc comment. 191
Method 'toMemIntArray' is not designed for extension - needs to be abstract, final or empty. 195
Missing a Javadoc comment. 195
Method 'toStringArray' is not designed for extension - needs to be abstract, final or empty. 199
Missing a Javadoc comment. 199
Array brackets at illegal position. 200
'256' is a magic number. 200
'256' is a magic number. 201
Method 'toMemObjectArray' is not designed for extension - needs to be abstract, final or empty. 207
Missing a Javadoc comment. 207
Array brackets at illegal position. 208
'256' is a magic number. 208
'256' is a magic number. 209
Expected an @return tag. 217
Method 'parseAddress' is not designed for extension - needs to be abstract, final or empty. 217
Parameter a should be final. 217
Expected @param tag for 'a'. 217
Expected an @return tag. 222
Method 'parseValue' is not designed for extension - needs to be abstract, final or empty. 222
Parameter a should be final. 222
Expected @param tag for 'a'. 222
'8' is a magic number. 223
'}' should be on the same line. 225
Expected an @return tag. 232
Method 'string2int' is not designed for extension - needs to be abstract, final or empty. 232
Parameter a should be final. 232
Expected @param tag for 'a'. 232
'8' is a magic number. 234
Array brackets at illegal position. 236
'128' is a magic number. 238
'64' is a magic number. 241
'32' is a magic number. 244
'3' is a magic number. 246
'16' is a magic number. 247
'4' is a magic number. 249
'8' is a magic number. 250
'5' is a magic number. 252
'4' is a magic number. 253
'6' is a magic number. 255
'7' is a magic number. 258
'}' should be on the same line. 262
'129' is a magic number. 264

org/mythsim/core/MythParserError.java

Error Line
Missing a header - not enough lines in file. 1
Line contains a tab character. 28
Missing a Javadoc comment. 28
Variable 'message' must be private and have accessor methods. 28
Line contains a tab character. 29
Missing a Javadoc comment. 29
Variable 'file' must be private and have accessor methods. 29
Line contains a tab character. 30
Missing a Javadoc comment. 30
Variable 'line' must be private and have accessor methods. 30
'=' is not preceeded with whitespace. 30
'=' is not followed by whitespace. 30
Line contains a tab character. 31
Missing a Javadoc comment. 31
'{' is not followed by whitespace. 31
'}' is not preceeded with whitespace. 31
Line contains a tab character. 32
Missing a Javadoc comment. 32
Parameter _message should be final. 32
Name '_message' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 32
Line contains a tab character. 33
Line contains a tab character. 34
Line contains a tab character. 36
Missing a Javadoc comment. 36
Parameter _file should be final. 36
Name '_file' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 36
Parameter _line should be final. 36
Name '_line' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 36
Parameter _message should be final. 36
Name '_message' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 36
Line contains a tab character. 37
Line contains a tab character. 38
Line contains a tab character. 39
Line contains a tab character. 40
Line contains a tab character. 41
Method 'message' is not designed for extension - needs to be abstract, final or empty. 41
Missing a Javadoc comment. 41
Line contains a tab character. 42
Line contains a tab character. 43
Line contains a tab character. 44

org/mythsim/core/MythSim.java

Error Line
Line does not match expected header line of ' GNU GENERAL PUBLIC LICENSE'. 1
Using the '.*' form of import should be avoided - java.io.*. 23
Name 'version_title' must match pattern '^[A-Z ] (_?[A-Z0-9 ] +)*$'. 33
'+' should be on a new line. 40
'+' should be on a new line. 41
'+' should be on a new line. 42
'+' should be on a new line. 43
Line is longer than 80 characters. 44
'+' should be on a new line. 44
Line is longer than 80 characters. 45
'+' should be on a new line. 45
'+' should be on a new line. 46
'+' should be on a new line. 47
'+' should be on a new line. 48
'+' should be on a new line. 49
'+' should be on a new line. 50
'+' should be on a new line. 51
'+' should be on a new line. 52
'+' should be on a new line. 53
'+' should be on a new line. 54
'+' should be on a new line. 55
Line is longer than 80 characters. 56
Variable 's' must be private and have accessor methods. 64
Array brackets at illegal position. 64
Variable 'p' must be private and have accessor methods. 67
Array brackets at illegal position. 67
Variable 'message' must be private and have accessor methods. 70
Name '_ucode' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 73
Variable '_ucode' must be private and have accessor methods. 73
Array brackets at illegal position. 73
Variable 'memoryFile' must be private and have accessor methods. 76
Missing a Javadoc comment. 77
Variable 'memorySource' must be private and have accessor methods. 77
Variable 'microcodeFile' must be private and have accessor methods. 80
Missing a Javadoc comment. 81
Variable 'microcodeSource' must be private and have accessor methods. 81
Method 'setFileMicrocode' is not designed for extension - needs to be abstract, final or empty. 84
Parameter file should be final. 84
Expected @param tag for 'file'. 84
Expected @throws tag for 'FileNotFoundException'. 84
'}' should be on the same line. 89
Method 'setFileMemory' is not designed for extension - needs to be abstract, final or empty. 96
Parameter file should be final. 96
Expected @param tag for 'file'. 96
Expected @throws tag for 'FileNotFoundException'. 96
'}' should be on the same line. 101
Missing a Javadoc comment. 107
Variable 'mp' must be private and have accessor methods. 107
Method 'getMemorySource' is not designed for extension - needs to be abstract, final or empty. 114
Method 'getMicrocodeSource' is not designed for extension - needs to be abstract, final or empty. 119
Method 'getMemoryFile' is not designed for extension - needs to be abstract, final or empty. 124
Method 'getMicrocodeFile' is not designed for extension - needs to be abstract, final or empty. 129
Method 'getMemoryFilePath' is not designed for extension - needs to be abstract, final or empty. 134
Method 'getMicrocodeFilePath' is not designed for extension - needs to be abstract, final or empty. 139
Method 'getMemoryFileName' is not designed for extension - needs to be abstract, final or empty. 144
Method 'getMicrocodeFileName' is not designed for extension - needs to be abstract, final or empty. 149
Line is longer than 80 characters. 316
Line is longer than 80 characters. 321
Line is longer than 80 characters. 326
Missing a Javadoc comment. 431
Missing a Javadoc comment. 432
Missing a Javadoc comment. 433
Missing a Javadoc comment. 434
Missing a Javadoc comment. 435
Missing a Javadoc comment. 436
Missing a Javadoc comment. 437
Missing a Javadoc comment. 438
Missing a Javadoc comment. 439
Missing a Javadoc comment. 440
Missing a Javadoc comment. 441
Missing a Javadoc comment. 442
Missing a Javadoc comment. 443
Missing a Javadoc comment. 444
Missing a Javadoc comment. 445
Missing a Javadoc comment. 446
Missing a Javadoc comment. 447
Missing a Javadoc comment. 448
Missing a Javadoc comment. 449
Missing a Javadoc comment. 450
Missing a Javadoc comment. 451
Missing a Javadoc comment. 452
Missing a Javadoc comment. 453
Missing a Javadoc comment. 454
Missing a Javadoc comment. 455
Missing a Javadoc comment. 456
Missing a Javadoc comment. 457
Missing a Javadoc comment. 481
Missing a Javadoc comment. 486
Missing a Javadoc comment. 533
Missing a Javadoc comment. 536
Missing a Javadoc comment. 539
Missing a Javadoc comment. 540
Missing a Javadoc comment. 541
Missing a Javadoc comment. 542
Missing a Javadoc comment. 547
Missing a Javadoc comment. 548
Missing a Javadoc comment. 549
Missing a Javadoc comment. 550
Variable 'mode' must be private and have accessor methods. 550
Method 'getStatus' is not designed for extension - needs to be abstract, final or empty. 554
Method 'getPreviousStatus' is not designed for extension - needs to be abstract, final or empty. 559
Method 'getStatus' is not designed for extension - needs to be abstract, final or empty. 564
Parameter index should be final. 564
Expected @param tag for 'index'. 564
Parameter i should be final. 569
Expected @param tag for 'i'. 569
Parameter i should be final. 574
Expected @param tag for 'i'. 574
'7' is a magic number. 575
'}' should be on the same line. 577
Method 'ucodeZero' is not designed for extension - needs to be abstract, final or empty. 584
Parameter index should be final. 589
Expected @param tag for 'index'. 589
Expected @throws tag for 'MythError'. 589
'255' is a magic number. 590
'5' is a magic number. 591
Parameter index should be final. 597
Expected @param tag for 'index'. 597
Parameter value should be final. 597
Expected @param tag for 'value'. 597
Expected @throws tag for 'MythError'. 597
'255' is a magic number. 598
'5' is a magic number. 599
Name 'lineNames' must match pattern '^[A-Z ] (_?[A-Z0-9 ] +)*$'. 605
Name 'displayNames' must match pattern '^[A-Z ] (_?[A-Z0-9 ] +)*$'. 634
Method 'getRegA' is not designed for extension - needs to be abstra ct, final or empty. 661
Missing a Javadoc comment. 661
'7' is a magic number. 662
'}' should be on the same line. 664
Method 'getRegB' is not designed for extension - needs to be abstract, final or empty. 670
Missing a Javadoc comment. 670
'7' is a magic number. 671
'}' should be on the same line. 673
Missing a Javadoc comment. 683
Name 'aluFuncs' must match pattern '^[A-Z ] (_?[A-Z0-9 ] +)*$'. 683
Method 'parse' is not designed for extension - needs to be abstract, final or empty. 790
Expected @throws tag for 'Exception'. 790
'}' should be on the same line. 795
'}' should be on the same line. 799
Method 'step' is not designed for extension - needs to be abstract, final or empty. 806
Parameter a should be final. 806
Expected @param tag for 'a'. 806
Expected @throws tag for 'MythError'. 806
Method 'next' is not designed for extension - needs to be abstract, final or empty. 830
Expected @throws tag for 'MythError'. 830
Expression can be simplified. 832
Method 'last' is not designed for extension - needs to be abstract, final or empty. 838
Expected @throws tag for 'MythError'. 838
'(' is followed by whitespace. 839
Expression can be simplified. 840
'(' is followed by whitespace. 841
Method 'run' is not designed for extension - needs to be abstract, final or empty. 846
Expected @throws tag for 'MythError'. 846
'1000' is a magic number. 847
Method 'boot' is not designed for extension - needs to be abstract, final or empty. 855
Expected @throws tag for 'MythError'. 855
Array brackets at illegal position. 870
'256' is a magic number. 871
'256' is a magic number. 874
Method 'step' is not designed for extension - needs to be abstract, final or empty. 882
Method length is 328 lines (max allowed is 150). 882
Expected @throws tag for 'MythError'. 882
'+' should be on a new line. 916
'+' should be on a new line. 920
'127' is a magic number. 937
'256' is a magic number. 940
'128' is a magic number. 942
'256' is a magic number. 945
Line is longer than 80 characters. 955
' & amp; & amp;' should be on a new line. 1103
' & amp; & amp;' should be on a new line. 1104
Line is longer than 80 characters. 1144
Must have at least one statement. 1186
'}' should be on the same line. 1187
'3' is a magic number. 1199
'}' should be on the same line. 1205
Must have at least one statement. 1206
Missing a Javadoc comment. 1215
Name 'NOT' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 1215
Parameter a should be final. 1215
Expression can be simplified. 1216
Missing a Javadoc comment. 1219
Name 'AND' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 1219
Parameter a should be final. 1219
Parameter b should be final. 1219
Missing a Javadoc comment. 1223
Name 'OR' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 1223
Paramete r a should be final. 1223
Parameter b should be final. 1223
Missing a Javadoc comment. 1227
Name 'XOR' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 1227
Parameter a should be final. 1227
Parameter b should be final. 1227
Missing a Javadoc comment. 1232
Parameter a should be final. 1232
Array brackets at illegal position. 1233
'8' is a magic number. 1233
'7' is a magic number. 1236
'128' is a magic number. 1237
'}' should be on the same line. 1238
'7' is a magic number. 1240
'64' is a magic number. 1242
'6' is a magic number. 1243
'64' is a magic number. 1244
'}' should be on the same line. 1245
'6' is a magic number. 1247
'32' is a magic number. 1249
'5' is a magic number. 1250
'32' is a magic number. 1251
'}' should be on the same line. 1252
'5' is a magic number. 1254
'16' is a magic number. 1256
'4' is a magic number. 1257
'16' is a magic number. 1258
'}' should be on the same line. 1259
'4' is a magic number. 1261
'8' is a magic number. 1263
'3' is a magic number. 1264
'8' is a magic number. 1265
'}' should be on the same line. 1266
'3' is a magic number. 1268
'4' is a magic number. 1270
'4' is a magic number. 1272
'}' should be on the same line. 1273
'}' should be on the same line. 1280
'}' should be on the same line. 1287
'}' should be on the same line. 1293
Missing a Javadoc comment. 1299
Array brackets at illegal position. 1299
Parameter a should be final. 1299
'8' is a magic number. 1300
'7' is a magic number. 1302
'128' is a magic number. 1303
'6' is a magic number. 1305
'64' is a magic number. 1306
'5' is a magic number. 1308
'32' is a magic number. 1309
'4' is a magic number. 1311
'16' is a magic number. 1312
'3' is a magic number. 1314
'8' is a magic number. 1315
'4' is a magic number. 1318
'}' should be on the same line. 1327
'129' is a magic number. 1329
Missing a Javadoc comment. 1333
Parameter a should be final. 1333
'}' should be on the same line. 1337
'256' is a magic number. 1339
Missing a Javadoc comment. 1345
Parameter a should be final. 1345
'128' is a magic number. 1347
'256' is a magic number. 1348
'}' should be on the same line. 1349
Missing a Javadoc comment. 1361
Parameter a should be final. 1361
Array brackets at illegal position. 1362
Missing a Javadoc comment. 1373
Parameter a should be final. 1373
Array brackets at illegal position. 1374
'7' is a magic number. 1376
'6' is a magic number. 1379
Missing a Javadoc comment. 1385
Parameter a should be final. 1385
Array brackets at illegal position. 1386
'5' is a magic number. 1388
'4' is a magic number. 1391
Missing a Javadoc comment. 1397
Parameter a should be final. 1397
Array brackets at illegal position. 1398
'7' is a magic number. 1400
'32' is a magic number. 1401
'6' is a magic number. 1403
'16' is a magic number. 1404
'5' is a magic number. 1406
'8' is a magic number. 1407
'4' is a magic number. 1409
'4' is a magic number. 1410
'3' is a magic number. 1412
Missing a Javadoc comment. 1422
Parameter a should be final. 1422
Array brackets at illegal position. 1423
'3' is a magic number. 1425
'128' is a magic number. 1426
'3' is a magic number. 1428
'64' is a magic number. 1429
'3' is a magic number. 1431
'32' is a magic number. 1432
'3' is a magic number. 1434
'16' is a magic number. 1435
'3' is a magic number. 1438
'8' is a magic number. 1439
'4' is a magic number. 1442
Missing a Javadoc comment. 1464
Parameter a should be final. 1464
Array brackets at illegal position. 1465
'7' is a magic number. 1466
Missing a Javadoc comment. 1472
Parameter a should be final. 1472
Array brackets at illegal position. 1473
'7' is a magic number. 1475
'128' is a magic number. 1476
'6' is a magic number. 1478
'64' is a magic number. 1479
'5' is a magic number. 1481
'32' is a magic number. 1482
'4' is a magic number. 1484
'16' is a magic number. 1485
'3' is a magic number. 1487
'8' is a magic number. 1488
'4' is a magic number. 1491
Missing a Javadoc comment. 1506
Variable 'opcodeTags' must be private and have accessor methods. 1506
Missing a Javadoc comment. 1523
Parameter x should be final. 1523
Array brackets at illegal position. 1524
'7' is a magic number. 1525
Expression can be simplified. 1526
Missing a Javadoc comment. 1531
Parameter x should be final. 1531
Parameter y should be final. 1531
Array brackets at illegal position. 1532
Array brackets at illegal position. 1533
'7' is a magic number. 1534
Missing a Javadoc comment. 1540
Parameter x should be final. 1540
Parameter y should be final. 1540
Array brackets at illegal position. 1541
Array brackets at illegal position. 1542
'7' is a magic number. 1543
Missing a Javadoc comment. 1549
Parameter x should be final. 1549
Parameter y should be final. 1549
Array brackets at illegal position. 1550
Array brackets at illegal position. 1551
'7' is a magic number. 1552
Line is longer than 80 characters. 1553
'(' is followed by whitespace. 1553
Expression can be simplified. 1553
Expression can be simplified. 1553
Expression can be simplified. 1553
Expression can be simplified. 1553
Missing a Javadoc comment. 1558
Parameter x should be final. 1558
'127' is a magic number. 1559
'128' is a magic number. 1562
Missing a Javadoc comment. 1568
Parameter x should be final. 1568
'127' is a magic number. 1569
'256' is a magic number. 1570
'128' is a magic number. 1572
'256' is a magic number. 1573
Missin g a Javadoc comment. 1578
Parameter x should be final. 1578
Parameter y should be final. 1578
'(' is followed by whitespace. 1579
Missing a Javadoc comment. 1586
Parameter alu_sel should be final. 1586
Name 'alu_sel' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 1586
Parameter a_bus should be final. 1586
Name 'a_bus' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 1586
Parameter b_bus should be final. 1586
Name 'b_bus' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 1586
Parameter c_in should be final. 1586
Name 'c_in' must match pattern '^[a-z ] [a-zA-Z0-9 ] *$'. 1586
'(' is followed by whitespace. 1598
'255' is a magic number. 1598
'(' is followed by whitespace. 1603
'255' is a magic number. 1603
'(' is followed by whitespace. 1608
'255' is a magic number. 1608
'(' is followed by whitespace. 1613
'255' is a magic number. 1613
'255' is a magic number. 1613
Missing a Javadoc comment. 1628
Array brackets at illegal position. 1629
Method 'getUstore' is not designed for extension - needs to be abstract, final or empty. 1636
Missing a Javadoc comment. 1636
Method 'getUcode' is not designed for extension - needs to be abstract, final or empty. 1640
Missing a Javadoc comment. 1640
Method 'getMemory' is not designed for extension - needs to be abstract, final or empty. 1644
Missing a Javadoc comment. 1644

org/mythsim/core/UcodeParser.java

Error Line
Line does not match expected header line of ' GNU GENERAL PUBLIC LICENSE'. 1
Using the '.*' form of import should be avoided - java.io.*. 24
Using the '.*' form of import should be avoided - java.util.*. 25
Line is longer than 80 characters. 32
'public' modifier out of order with the JLS suggestions. 37
'private' modifier out of order with the JLS suggestions. 40
'public' modifier out of order with the JLS suggestions. 43
'private' modifier out of order with the JLS suggestions. 48
Name 'yycmap' must match pattern '^[A-Z ] (_?[A-Z0-9 ] +)*$'. 48
'44' is a magic number. 49
'45' is a magic number. 49
'45' is a magic number. 51
'4' is a magic number. 51
'43' is a magic number. 51
'15' is a magic number. 52
'20' is a magic number. 52
'21' is a magic number. 52
'22' is a magic number. 52
'23' is a magic number. 52
'24' is a magic number. 52
'25' is a magic number. 52
'26' is a magic number. 52
'38' is a magic number. 52
'11' is a magic number. 52
'13' is a magic number. 52
'42' is a magic number. 52
'27' is a magic number. 53
'30' is a magic number. 53
'7' is a magic number. 53
'8' is a magic number. 53
'9' is a magic number. 53
'40' is a magic number. 53
'39' is a magic number. 53
'37' is a magic number. 53
'18' is a magic number. 53
'31' is a magic number. 53
'32' is a magic number. 53
'29' is a magic number. 53
'36' is a magic number. 53
'33' is a magic number. 53
'5' is a magic number. 53
'6' is a magic number. 54
'3' is a magic number. 54
'14' is a magic number. 54
'28' is a magic number. 54
'19' is a magic number. 54
'34' is a magic number. 54
'41' is a magic number. 54
'17' is a magic number. 54
'35' is a magic number. 54
'3' is a magic number. 54
'3' is a magic number. 54
'10' is a magic number. 54
'12' is a magic number. 54
'16' is a magic number. 54
'27' is a magic number. 55
'30' is a magic number. 55
'7' is a magic number. 55
'8' is a magic number. 55
'9' is a magic number. 55
'40' is a magic number. 55
'39' is a magic number. 55
'37' is a magic number. 55
'18' is a magic number. 55
'31' is a magic number. 55
'32' is a magic number. 55
'29' is a magic number. 55
'36' is a magic number. 55
'33' is a magic number. 55
'5' is a magic number. 55
'6' is a magic number. 56
'3' is a magic number. 56
'14' is a magic number. 56
'28' is a magic number. 56
'19' is a magic number. 56
'34' is a magic number. 56
'41' is a magic number. 56
'17' is a magic number. 56
'35' is a magic number. 56
'3' is a magic number. 56
'3' is a magic number. 56
'private' modifier out of order with the JLS suggestions. 62
Name 'yy_rowMap' must match pattern '^[A-Z ] (_?[A-Z0-9 ] +)*$'. 62
Array brackets at illegal position. 62
'46' is a magic number. 63
'92' is a magic number. 63
'138' is a magic number. 63
'184' is a magic number. 63
'230' is a magic number. 63
'276' is a magic number. 63
'322' is a magic number. 63
'368' is a magic number. 63
'414' is a magic number. 63
'460' is a magic number. 64
'506' is a magic number. 64
'552' is a magic number. 64
'598' is a magic number. 64
'644' is a magic number. 64
'46' is a magic number. 64
'138' is a magic number. 64
'46' is a magic number. 64
'690' is a magic number. 64
'736' is a magic number. 64
'782' is a magic number. 65
'828' is a magic number. 65
'874' is a magic number. 65
'920' is a magic number. 65
'966' is a magic number. 65
'1012' is a magic number. 65
'1058' is a magic number. 65
'1104' is a magic number. 65
'1150' is a magic number. 65
'1196' is a magic number. 65
'1242' is a magic number. 66
'1288' is a magic number. 66
'1334' is a magic number. 66
'1380' is a magic number. 66
'1426' is a magic number. 66
'1472' is a magic number. 66
'1518' is a magic number. 66
'1564' is a magic number. 66
'1610' is a magic number. 66
'46' is a magic number. 66
'1656' is a magic number. 67
'1702' is a magic number. 67
'1748' is a magic number. 67
'598' is a magic number. 67
'1794' is a magic number. 67
'1840' is a magic number. 67
'1886' is a magic number. 67
'1932' is a magic number. 67
'1978' is a magic number. 67
'2024' is a magic number. 67
'2070' is a magic number. 68
'2116' is a magic number. 68
'2162' is a magic number. 68
'2208' is a magic number. 68
'2254' is a magic number. 68
'2300' is a magic number. 68
'2346' is a magic number. 68
'2392' is a magic number. 68
'2438' is a magic number. 68
'2484' is a magic n umber. 68
'2530' is a magic number. 69
'2576' is a magic number. 69
'2622' is a magic number. 69
'2668' is a magic number. 69
'2714' is a magic number. 69
'2760' is a magic number. 69
'2806' is a magic number. 69
'2852' is a magic number. 69
'2898' is a magic number. 69
'2944' is a magic number. 69
'2990' is a magic num ber. 70
'138' is a magic number. 70
'138' is a magic number. 70
'3036' is a magic number. 70
'3082' is a magic number. 70
'3128' is a magic number. 70
'3174' is a magic number. 70
'3220' is a magic number. 70
'3266' is a magic number. 70
'3312' is a magic number. 70
'3358' is a magic number. 71
'3404' is a magic number. 71
'3450' is a magic number. 71
'3496' is a magic number. 71
'3542' is a magic number. 71
'3588' is a magic number. 71
'3634' is a magic number. 71
'3680' is a magic number. 71
'3726' is a magic number. 71
'3772' is a magic number. 71
'3818' is a magic number. 72
'3864' is a magic number. 72
'3910' is a magic number. 72
'3956' is a magic number. 72
'4002' is a magic number. 72
'4048' is a magic number. 72
'4094' is a magic number. 72
'4140' is a magic number. 72
'4186' is a magic number. 72
'4232' is a magic number. 72
'4278' is a magic number. 73
'4324' is a magic number. 73
'4370' is a magic number. 73
'4416' is a magic number. 73
'4462' is a magic number. 73
'4508' is a magic number. 73
'4554' is a magic number. 73
'4600' is a magic number. 73
'4646' is a magic number. 73
'4692' is a magic number. 73
'4738' is a magic number. 74
'138' is a magic number. 74
'4784' is a magic number. 74
'4830' is a magic number. 74
'4876' is a magic number. 74
'4922' is a magic number. 74
'4968' is a magic number. 74
'5014' is a magic number. 74
'5060' is a magic number. 74
'5106' is a magic number. 74
'5152' is a magic number. 75
'5198' is a magic number. 75
'5244' is a magic number. 75
'5290' is a magic number. 75
'5336' is a magic number. 75
'5382' is a magic number. 75
'5428' is a magic number. 75
'138' is a magic number. 75
'5474' is a magic number. 75
'5520' is a magic number. 75
'5566' is a magic number. 76
'5612' is a magic number. 76
'5658' is a magic number. 76
'5704' is a magic number. 76
'5750' is a magic number. 76
'138' is a magic number. 76
'138' is a magic number. 76
'5796' is a magic number. 76
'5842' is a magic number. 76
'5888' is a magic number. 76
'5934' is a magic number. 77
'5980' is a magic number. 77
'6026' is a magic number. 77
'6072' is a magic number. 77
'6118' is a magic number. 77
'6164' is a magic number. 77
'6210' is a magic number. 77
'6256' is a magic number. 77
'6302' is a magic number. 77
'6348' is a magic number. 77
'6394' is a magic number. 78
'6440' is a magic number. 78
'6486' is a magic number. 78
'6532' is a magic number. 78
'6578' is a magic number. 78
'6624' is a magic number. 78
'6670' is a magic number. 78
'6716' is a magic number. 78
'6762' is a magic number. 78
'6808' is a magic number. 78
'6854' is a magic number. 79
'6900' is a magic number. 79
'6946' is a magic number. 79
'6992' is a magic number. 79
'7038' is a magic number. 79
'7084' is a magic number. 79
'7130' is a magic number. 79
'7176' is a magic number. 79
'46' is a magic number. 79
'46' is a magic number. 79
'46' is a magic number. 80
'46' is a magic number. 80
'46' is a magic number. 80
'46' is a magic number. 80
'46' is a magic number. 80
'46' is a magic number. 80
'7222' is a magic number. 80
'46' is a magic number. 80
'46' is a magic number. 80
'46' is a magic number. 80
'46' is a magic number. 81
'46' is a magic number. 81
'46' is a magic number. 81
'46' is a magic number. 81
'46' is a magic number. 81
'7268' is a magic number. 81
'7314' is a magic number. 81
'7360' is a magic number. 81
'7406' is a magic number. 81
'7452' is a magic number. 81
'138' is a magic number. 82
'138' is a magic number. 82
'138' is a magic number. 82
'138' is a magic number. 82
'138' is a magic number. 82
'138' is a magic number. 82
'138' is a magic number. 82
'138' is a magic number. 82
'7498' is a magic number. 82
'7544' is a magic number. 82
'7590' is a magic number. 83
'7636' is a magic number. 83
'7682' is a magic number. 83
'7728' is a magic number. 83
'7774' is a magic number. 83
'7820' is a magic number. 83
'7866' is a magic number. 83
'7912' is a magic number. 83
'7958' is a magic number. 83
'8004' is a magic number. 83
'8050' is a magic number. 84
'8096' is a magic number. 84
'8142' is a magic number. 84
'8188' is a magic number. 84
'8234' is a magic number. 84
'46' is a magic number. 84
'46' is a magic number. 84
'8280' is a magic number. 84
'8326' is a magic number. 84
'46' is a magic number. 84
'46' is a magic number. 85
'8372' is a magic number. 85
'8418' is a magic number. 85
'8464' is a magic number. 85
'8510' is a magic number. 85
'8556' is a magic number. 85
'8602' is a magic number. 85
'8648' is a magic number. 85
'46' is a magic number. 85
'46' is a magic number. 85
'46' is a magic number. 86
'46' is a magic number. 86
'46' is a magic number. 86
'46' is a magic number. 86
'46' is a magic number. 86
'46' is a magic number. 86
'8694' is a magic number. 86
'8740' is a magic number. 86
'8786' is a magic number. 86
'8832' is a magic number. 86
'46' is a magic number. 87
'46' is a magic number. 87
'46' is a magic number. 87
'8878' is a magic number. 87
'8924' is a magic number. 87
'46' is a magic number. 87
'46' is a magic number. 87
'8970' is a magic number. 87
'9016' is a magic number. 87
'9062' is a magic number. 87
'9108' is a magic number. 88
'9154' is a magic number. 88
'9200' is a magic number. 88
'9246' is a magic number. 88
'9292' is a magic number. 88
'9338' is a magic number. 88
'9384' is a magic number. 88
'9430' is a magic number. 88
'9476' is a magic number. 88
'9522' is a magic number. 88
'9568' is a magic number. 89
'9614' is a magic number. <